Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get MojangProfile username from the request #60

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Get MojangProfile username from the request #60

merged 2 commits into from
Dec 19, 2024

Conversation

bumpyJake
Copy link
Contributor

@bumpyJake bumpyJake commented Dec 18, 2024 •
edited
Loading

Change MojangProfileAPI to include the name returned from the API Call in the MojangProfile, instead of the username initially entered into the function

MarcusSlover
MarcusSlover approved these changes Dec 19, 2024
View reviewed changes
Copy link
Owner

@MarcusSlover MarcusSlover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MarcusSlover MarcusSlover merged commit 6493734 into MarcusSlover:master Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusSlover MarcusSlover MarcusSlover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bumpyJake @MarcusSlover